I think elves have a choice whether they want to come back or not

My understanding is that the Elves of Middle Earth, upon their ‘death,’ return to the halls of Mandos in Valinor to ponder their past life. When they are ready, they join their kindred in Valinor. They almost always choose to stay, and who wouldn’t? Middle Earth is a land of struggle, with evil and suffering everywhere, dominated by Men after the First Age. Valinor is a land of peace & plenty, with only Elves, and the Valar live there. Even on the island of Tol Eressea, they have peace, music, and a very good life.

Being immortal, the Elves of Valinor have the option to return to Middle Earth. Very few do. Glorfindel returned because he was needed, he was strong & wise & was a worthy addition to Elrond’s home. In the end it was his choice. Though of course he would have been discouraged.

For your question on Fëanor/Fingolfin, as I understand it, different Elves have different wait periods to attain their "resurrection", depending on their actions while they were in their body. Some have longer wait periods than others, and some are denied resurrection altogether. I believe Fëanor and all his sons were denied resurrection because of their deeds in the Kinslayings. But even without the whole Kinslaying thing, Mandos denied resurrection to almost all the Noldorian Exiles, with only a few exceptions, such as Glorfindel and Finrod Felagund. Thus, many of the "great" elves from the First Age probably had to wait in the Halls of Mandos until the end of time.

This article might be helpful in understanding elven reincarnation.

Exactly.

Felagund was more of a creator and a forger than a warrior/protector, so he would have been less useless. Felagund is actually a Dwarvish addition to his name.

Thanks for all of your guys’ answers, they’ve been really useful